[ARIES-1700] A possible null pointer

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: blueprint-core-1.7.0
• Fix Version/s: blueprint-noosgi-1.1.3
• Component/s: Blueprint
• Assignee: Guillaume Nodet
• Reporter: Hao Zhong
• Created: 16/Mar/17 11:22
• Updated: 20/Mar/17 14:19
• Resolved: 20/Mar/17 14:19

Description

The current version of NoOsgiRecipeBuilder has the following code:
else if (v instanceof IdRefMetadata)

{ // TODO: make it work with property-placeholders? String componentName = ((IdRefMetadata) v).getComponentId(); IdRefRecipe rnr = new IdRefRecipe(getName(null), componentName); return rnr; }

else

{ throw new IllegalStateException("Unsupported value: " + v.getClass().getName()); }

Here, v.getClass() can return null. The line shall be revised as:
throw new IllegalStateException("Unsupported value: " + (v != null ? v.getClass().getName() : "null"));

Indeed, I notice that the file, RecipeBuilder, has the following similar code:

else if (v instanceof IdRefMetadata)

{ // TODO: make it work with property-placeholders? String componentName = ((IdRefMetadata) v).getComponentId(); IdRefRecipe rnr = new IdRefRecipe(getName(null), componentName); return rnr; }

else

{ throw new IllegalStateException("Unsupported value: " + (v != null ? v.getClass().getName() : "null")); }

It checks whether v is null or not.