[ARIES-1612] Zip input stream relies on default (non buffered) InputStream read

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: util-1.1.1
• Fix Version/s: util-1.1.2
• Component/s: Util
• Assignee: Tom Watson
• Reporter: Paul Thevenot
• Created: 12/Sep/16 07:29
• Updated: 19/Jun/17 12:49
• Resolved: 14/Sep/16 20:39

Description

We have performances issues on application startup. It takes a while to install all the bundles of a subsystem. After a quick look with JProfiler, we saw that the SpecialZipInputStream.read() was invoked 44 millions times during startup.
We're using the Felix framework and the BundleCache.copyStreamToFile calls the method read(byte[] b) from the InputStream. Unfortunately, the method read(byte[] b) and read(byte[] b, int off, int len) are not overriden by the SpecialZipInputStream (thus we don't buffer the read).
Completing the decoration in the SpecialZipInputStream solved this problem and divided the startup time by two.

I've made the pull request with the requested change https://github.com/apache/aries/pull/55

Issue Links

• is related to: ARIES-1565 Performance Improvement: unpack subsystem artifacts to tmp folder to avoid directly reading from zip archive
• links to: GitHub Pull Request #55