[ARIES-1439] Aries ResolveContext.insertHostedCapability() calls unsupported add() method on capabilies

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: subsystem-core-2.0.4
• Fix Version/s: subsystem-2.0.6
• Component/s: Subsystem
• Assignee: David Bosschaert
• Reporter: David Bosschaert
• Created: 27/Oct/15 15:06
• Updated: 12/Nov/15 15:06
• Resolved: 27/Oct/15 16:07

Description

The method

org.apache.aries.subsystem.core.internal.ResolveContext.insertHostedCapability(List<Capability> capabilities, HostedCapability hostedCapability)

calls capabilities.add(hostedCapability).

However the key reason for this callback is to insert this capability at the correct position in the capabilities list. The Felix implementation of the List provided insist on a call to add(idx, capability) which seems to make sense in this context.

Currently this call causes the following exception:

java.lang.UnsupportedOperationException: null
	at org.apache.felix.resolver.util.CopyOnWriteList.add(CopyOnWriteList.java:135)
	at org.apache.aries.subsystem.core.internal.ResolveContext.insertHostedCapability(ResolveContext.java:101)
	at org.apache.felix.resolver.Candidates.prepare(Candidates.java:934)
	at org.apache.felix.resolver.ResolverImpl.resolve(ResolverImpl.java:232)
	at org.apache.felix.resolver.ResolverImpl.resolve(ResolverImpl.java:158)
	at org.apache.aries.subsystem.core.internal.SubsystemResource.computeDependencies(SubsystemResource.java:372)