[ARIES-1390] BasicCapability should take advantage of the effective immutability of capabilities.

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: subsystem-2.0.2
• Fix Version/s: subsystem-core-2.0.4, subsystem-bundle-2.0.4
• Component/s: Subsystem
• Labels: perfomance
• Assignee: John Ross
• Reporter: John Ross
• Created: 29/Aug/15 08:11
• Updated: 22/Oct/15 12:23
• Resolved: 22/Oct/15 12:23

Description

Currently, when given an already existing Capability at construction, BasicCapability will make a copy of the attributes and directives. This is not really necessary since a properly implemented Capability will be effectively immutable as required by the OSGi API.

Profiling showed that BasicCapability(Capability, Resource) was taking up 4.6%, or 1550 ms, of the total time. After the optimization, this no longer registered with a sampling time of 50 ms.

BasicCapability(Capability, Resource) will now simply reuse the already existing, and effectively immutable, attribute and directive maps of the provided capability.

Issue Links

• blocks: ARIES-1377 Subsystems 2.0.4 Release
• relates to: ARIES-1357 BasicSubsystem can be used by the subsystem install process a factor 6 times faster