[ARIES-1388] Compute requirement filters only once.

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: subsystem-2.0.2
• Fix Version/s: subsystem-core-2.0.4, subsystem-bundle-2.0.4
• Component/s: Subsystem
• Labels: performance
• Assignee: John Ross
• Reporter: John Ross
• Created: 28/Aug/15 15:56
• Updated: 22/Oct/15 12:23
• Resolved: 22/Oct/15 12:23

Description

ResourceHelper.matches(Requirement, Capability) is an often used method during resolution. Currently, it recomputes the requirement filter with each call.

The measurements used the same test scenario being developed as part of ARIES-1357. The time it took to install 50 features was measured. Each feature consists of 10 bundles plus one application. All features share the same 10 bundles. Each bundle exports 5 unique packages. Each application consists of 10 unique bundles. The bundles import packages offered by the containing feature.

The baseline average time for installing all 50 features was 67.9 seconds.

AbstractRequirement will now lazily compute the requirement filter when asked for the first time. Subsequent calls will return the already computed value.

ResourceHelper now asks whether or not the Requirement is an instance of AbstractRequirement. If so, it asks for the filter directly. If not, the filter is computed as before.

After these modifications, the average time for installing all 50 features was 46.6 seconds, a 31.3% improvement.

Issue Links

• blocks: ARIES-1377 Subsystems 2.0.4 Release
• relates to: ARIES-1357 BasicSubsystem can be used by the subsystem install process a factor 6 times faster