Maven Archetype
  1. Maven Archetype
  2. ARCHETYPE-360

Wrong assignment in loop results in wrong debug log output

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.1
    • Component/s: Generator
    • Labels:
      None

      Description

      The "artifactId" parameter in the processFilesetModule() method is reassigned in the while loop iterating over submodules, but the parameter is not used in the loop.

      The only consequence of that is that the artifact ID logged by the getLogger().debug( "Processed " + artifactId ); line at the end of the method does not match the artifact ID logged at the start of the method getLogger().debug( "Processing module " + artifactId ); if there are submodules.

      Proposal: Just delete the line, see attached patch file.

        Activity

        Marc Wirth created issue -
        Hervé Boutemy made changes -
        Field Original Value New Value
        Description The "artifactId" parameter in the processFilesetModule() method is reassigned in the while loop iterating over submodules, but the parameter is not used in the loop.

        The only consequence of that is that the artifact ID logged by the {{ getLogger().debug( "Processed " + artifactId );}} line at the end of the method does not match the artifact ID logged at the start of the method {{getLogger().debug( "Processing module " + artifactId );}} if there are submodules.

        Proposal: Just delete the line, see attached patch file.
        The "artifactId" parameter in the processFilesetModule() method is reassigned in the while loop iterating over submodules, but the parameter is not used in the loop.

        The only consequence of that is that the artifact ID logged by the {{getLogger().debug( "Processed " + artifactId );}} line at the end of the method does not match the artifact ID logged at the start of the method {{getLogger().debug( "Processing module " + artifactId );}} if there are submodules.

        Proposal: Just delete the line, see attached patch file.
        Hide
        Hervé Boutemy added a comment -

        patch applied in r1063055
        thank you

        Show
        Hervé Boutemy added a comment - patch applied in r1063055 thank you
        Hervé Boutemy made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Closed [ 6 ]
        Assignee Herve Boutemy [ hboutemy ]
        Fix Version/s 2.1 [ 16795 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 09:05:55 UTC 2015 [ 1428224755734 ]
        Mark Thomas made changes -
        Workflow jira [ 12716798 ] Default workflow, editable Closed status [ 12748097 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 22:17:37 UTC 2015 [ 1428272257260 ]
        Mark Thomas made changes -
        Workflow jira [ 12953860 ] Default workflow, editable Closed status [ 12990996 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        12d 7h 5m 1 Hervé Boutemy 24/Jan/11 17:16

          People

          • Assignee:
            Hervé Boutemy
            Reporter:
            Marc Wirth
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development