[APLO-221] Documentation Incorrect regarding default credit window for a STOMP subscription

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.3
• Fix Version/s: 1.5
• Component/s: apollo-website
• Assignee: Hiram R. Chirino
• Reporter: Christian Posta
• Created: 13/Jul/12 13:41
• Updated: 28/Sep/12 17:22
• Resolved: 28/Sep/12 17:22

Description

From the docs on page: http://activemq.apache.org/apollo/documentation/user-manual.html#Subscription_Flow_Control:

"If the credit header is not specified it has the same effect as if it had been set to credit:1,65536"

According to this code, it would default to credit:655360,655360:

(StompProtocolHandler.on_stomp_subscribe()):

val credit_window = get(headers, CREDIT) match {
case Some(value) =>
value.toString.split(",").toList match

{ case x :: Nil => InitialCreditWindow(x.toInt, buffer_size, true) case x :: y :: Nil => InitialCreditWindow(x.toInt, y.toInt, true) case x :: y :: z :: _ => InitialCreditWindow(x.toInt, y.toInt, z.toBoolean) case _ => InitialCreditWindow(buffer_size, buffer_size, true) }

case None =>
InitialCreditWindow(buffer_size, buffer_size, true)
}