[APEXCORE-737] AppMaster does not shut down because numRequestedContainers becomes negative

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.7.0
• Assignee: Sanjay M Pujare
• Reporter: Sanjay M Pujare
• Created: 02/Jun/17 02:51
• Updated: 27/Apr/18 13:35
• Resolved: 11/Aug/17 23:11

Description

A previous fix (for APEXCORE-624) has introduced a regression where numRequestedContainers inside StreamingAppMasterService.execute() becomes negative because instead of incrementing numRequestedContainers it is being decremented under certain conditions as follows:

While processing the YARN response of container allocation/release request, numRequestContainers is decremented by newAllocatedContainers.size() (correctly). However in case of (alreadyAllocated == true) the decrement should be undone by incrementing numRequestContainers (i.e. numRequestContainers++). However the current code is decrementing again (i.e. numRequestContainers--) on line 886

Issue Links

• is broken by: APEXCORE-624 Shutdown does not work because of incorrect logic in the AppMaster
• links to: GitHub Pull Request #535