Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      The since tag is inserted in the license header instead of the class comment.

        Issue Links

          Activity

          Hide
          thw Thomas Weise added a comment -

          The following script can be used as workaround:

          https://issues.apache.org/jira/secure/attachment/12781158/add-since.rb

          Show
          thw Thomas Weise added a comment - The following script can be used as workaround: https://issues.apache.org/jira/secure/attachment/12781158/add-since.rb
          Hide
          thw Thomas Weise added a comment -

          Just discovered that this plugin does not handle (removes) custom tags:

          +++ b/contrib/src/main/java/com/datatorrent/contrib/accumulo/AbstractAccumuloOutputOperator.java
          @@ -49,9 +49,9 @@ import com.google.common.collect.Lists;
            * restarted from an earlier checkpoint. It only tries to minimize the number of
            * duplicates limiting it to the tuples that were processed in the window when
            * the operator shutdown.
          + *
            * @displayName Abstract Accumulo Output
            * @category Output
          - * @tags accumulo, key value
            * @param <T>
            *            The tuple type
            * @since 1.0.4
          
          Show
          thw Thomas Weise added a comment - Just discovered that this plugin does not handle (removes) custom tags: +++ b/contrib/src/main/java/com/datatorrent/contrib/accumulo/AbstractAccumuloOutputOperator.java @@ -49,9 +49,9 @@ import com.google.common.collect.Lists; * restarted from an earlier checkpoint. It only tries to minimize the number of * duplicates limiting it to the tuples that were processed in the window when * the operator shutdown. + * * @displayName Abstract Accumulo Output * @category Output - * @tags accumulo, key value * @param <T> * The tuple type * @since 1.0.4
          Hide
          thw Thomas Weise added a comment -
          yes | mvn javadoc:fix -DdefaultSince=3.2.0 -DfixTags=since -DignoreClirr=true -DfixFieldComment=false -DfixMethodComment=false
          

          This is caused by the license header starting with /** instead of /*

          wrong:

          +++ b/engine/src/main/java/com/datatorrent/stram/webapp/asm/CompactFieldNode.java
          @@ -1,3 +1,4 @@
          +
           /**
            * Licensed to the Apache Software Foundation (ASF) under one
            * or more contributor license agreements.  See the NOTICE file
          @@ -15,6 +16,8 @@
            * KIND, either express or implied.  See the License for the
            * specific language governing permissions and limitations
            * under the License.
          + *
          + * @since 3.2.0
            */
           package com.datatorrent.stram.webapp.asm;
           
          diff --git a/engine/src/main/java/com/datatorrent/stram/webapp/asm/FieldSignatureVisitor.java b/engine/src/main/java/com/datatorrent/stram/webapp/asm/FieldSignatureVisitor.java
          index c58fe7b..1c63d5b 100644
          --- a/engine/src/main/java/com/datatorrent/stram/webapp/asm/FieldSignatureVisitor.java
          

          correct:

          +++ b/engine/src/main/java/com/datatorrent/stram/webapp/asm/FieldSignatureVisitor.java
          @@ -1,4 +1,4 @@
          -/**
          +/*
            * Licensed to the Apache Software Foundation (ASF) under one
            * or more contributor license agreements.  See the NOTICE file
            * distributed with this work for additional information
          @@ -20,6 +20,11 @@ package com.datatorrent.stram.webapp.asm;
           
           
           import org.apache.xbean.asm5.signature.SignatureVisitor;
          +/**
          + * <p>FieldSignatureVisitor class.</p>
          + *
          + * @since 3.2.0
          + */
           public class FieldSignatureVisitor extends BaseSignatureVisitor{
           
             private Type fieldType;
          
          Show
          thw Thomas Weise added a comment - yes | mvn javadoc:fix -DdefaultSince=3.2.0 -DfixTags=since -DignoreClirr= true -DfixFieldComment= false -DfixMethodComment= false This is caused by the license header starting with /** instead of /* wrong: +++ b/engine/src/main/java/com/datatorrent/stram/webapp/asm/CompactFieldNode.java @@ -1,3 +1,4 @@ + /** * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file @@ -15,6 +16,8 @@ * KIND, either express or implied. See the License for the * specific language governing permissions and limitations * under the License. + * + * @since 3.2.0 */ package com.datatorrent.stram.webapp.asm; diff --git a/engine/src/main/java/com/datatorrent/stram/webapp/asm/FieldSignatureVisitor.java b/engine/src/main/java/com/datatorrent/stram/webapp/asm/FieldSignatureVisitor.java index c58fe7b..1c63d5b 100644 --- a/engine/src/main/java/com/datatorrent/stram/webapp/asm/FieldSignatureVisitor.java correct: +++ b/engine/src/main/java/com/datatorrent/stram/webapp/asm/FieldSignatureVisitor.java @@ -1,4 +1,4 @@ -/** +/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information @@ -20,6 +20,11 @@ package com.datatorrent.stram.webapp.asm; import org.apache.xbean.asm5.signature.SignatureVisitor; +/** + * <p>FieldSignatureVisitor class.</p> + * + * @since 3.2.0 + */ public class FieldSignatureVisitor extends BaseSignatureVisitor{ private Type fieldType;

            People

            • Assignee:
              Unassigned
              Reporter:
              thw Thomas Weise
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:

                Development