[ANY23-330] Clean up Any23PluginManager

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.1
• Fix Version/s: 2.8
• Component/s: Plugin Management
• Assignee: Unassigned
• Reporter: Hans Brende
• Created: 01/Mar/18 09:41
• Updated: 21/Feb/22 18:24

Description

I've been peeking at the Any23PluginManager class. There are a few issues:

1. getPlugins(Class<T>), getTools(), getExtractors(), and getApplicableTools() never throw any exceptions, yet they all declare: throws IOException.

2. configureExtractors(File...), configureExtractors(ExtractorGroup), and getApplicableExtractors(ExtractorRegistry, File...) all throw ServiceConfigurationError, but instead declare: throws IOException, IllegalAccessException, InstantiationException (none of which are ever thrown).

3. getApplicableExtractors(ExtractorRegistry, File...) never uses the ExtractorRegistry argument. Behavior is identical to configureExtractors(File...). Behavior does not match javadoc.

4. configureExtractors(ExtractorGroup) never uses the ExtractorGroup argument (but this deleting this parameter would create confusion with the variadic configureExtractors(File...) method). Behavior does not match javadoc.

I'd argue that some of these methods are completely useless and should be removed. None of them are being used in the OpenIE dynamic jar loading example in the web service except getExtractors().

Note: after these issues are resolved, we may have to revisit ANY23-333.