[AMQNET-378] Collection modified exception in Connection.Close() when using temp destinations.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.3
• Fix Version/s: 1.5.4
• Assignee: Jim Gomes
• Reporter: Tom
• Created: 10/Apr/12 10:44
• Updated: 11/Apr/12 00:58
• Resolved: 11/Apr/12 00:58

Description

Collection Connection.tempDests is modified during enumeration and results in an exception and a failure to close connections.

In Connection Close()

foreach(ActiveMQTempDestination dest in this.tempDests.Values)
{
    dest.Delete();
}

In ActiveMQTempDestination..

public void Delete()
        {
            if(this.connection != null)
            {
                this.connection.DeleteTemporaryDestination(this);
            }
        }

Connection.DeleteTemporaryDestination..

public void DeleteTemporaryDestination(IDestination destination)
		{
            CheckClosedOrFailed();

            ActiveMQTempDestination temp = destination as ActiveMQTempDestination;

            foreach(Session session in this.sessions)
            {
                if(session.IsInUse(temp))
                {
                    throw new NMSException("A consumer is consuming from the temporary destination");
                }
            }

            this.tempDests.Remove(destination as ActiveMQTempDestination);
			this.DeleteDestination(destination);
		}