[AMQCPP-612] System::arraycopy weird tests

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 3.9.5
• Component/s: Decaf
• Assignee: Timothy A. Bish
• Reporter: David Carlier
• Created: 28/Mar/17 13:08
• Updated: 28/Mar/17 13:09

Description

Hi,

I was reading the source code especially System::arraycopy family methods :

https://git-wip-us.apache.org/repos/asf?p=activemq-cpp.git;a=blob;f=activemq-cpp/src/main/decaf/lang/System.cpp;h=199dd660ca58a23862e93109fa9827444728bf13;hb=HEAD#l120

and was wonderined if :

• Testing twice src was intentional since I suppose it should be dest as second test for example ?
• Should not it be always memmove since src and dest can still overlap ?

Regards.