ActiveMQ C++ Client
  1. ActiveMQ C++ Client
  2. AMQCPP-419

Missing dependency on apr/apr-util in pkg-config and config files

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5.0
    • Fix Version/s: 3.5.0
    • Component/s: CMS Impl, Decaf
    • Labels:
    • Patch Info:
      Patch Available

      Description

      Decaf header files depends on headers in apr and apr-util packages, which is not covered by activemq-cpp.pc and activemq-config files.

      I'm sending a patch which adds a necessary flags and includes.

      1. pkg-config-apr.diff
        1 kB
        František Dvořák
      2. apr-devel.diff
        2 kB
        František Dvořák

        Activity

        František Dvořák made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Timothy Bish made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Timothy Bish added a comment -

        Applied corrected part of the patch, looks good.

        Show
        Timothy Bish added a comment - Applied corrected part of the patch, looks good.
        Hide
        František Dvořák added a comment -

        I'm sorry, bad wording. Only projects using activemq-cpp, pkg-config, and with apr/apr-util in non-standard prefix would need set the PKG_CONFIG_PATH variable (which I think is common thing, when using pkg-config to search libraries).

        But copying the CFLAGS directly into activemq-cpp.pc file will work too (although it's probably not so clean), and it's one-line change.

        Show
        František Dvořák added a comment - I'm sorry, bad wording. Only projects using activemq-cpp, pkg-config, and with apr/apr-util in non-standard prefix would need set the PKG_CONFIG_PATH variable (which I think is common thing, when using pkg-config to search libraries). But copying the CFLAGS directly into activemq-cpp.pc file will work too (although it's probably not so clean), and it's one-line change.
        Hide
        Timothy Bish added a comment -

        User should not need to set env vars to make the configure work, and if they did you need to include significant documentation which this patch doesn't do.

        Show
        Timothy Bish added a comment - User should not need to set env vars to make the configure work, and if they did you need to include significant documentation which this patch doesn't do.
        František Dvořák made changes -
        Attachment pkg-config-apr.diff [ 12539863 ]
        Hide
        František Dvořák added a comment -

        Right, there were a problem in regular expression when apr/apr-util were installed in non-standard prefix.

        Attaching fixed patch (tested with --with-apr and --with-apr-util options, and with apr/apr-util in standard paths).

        I think we can let only the pkg-config dependency on apr-1 and apr-util-1 instead of copying the flags. With apr/apr-util in non-standard path, user must set environment variable PKG_CONFIG_PATH (pkg-config will properly complain, if there will be something wrong).

        Show
        František Dvořák added a comment - Right, there were a problem in regular expression when apr/apr-util were installed in non-standard prefix. Attaching fixed patch (tested with --with-apr and --with-apr-util options, and with apr/apr-util in standard paths). I think we can let only the pkg-config dependency on apr-1 and apr-util-1 instead of copying the flags. With apr/apr-util in non-standard path, user must set environment variable PKG_CONFIG_PATH (pkg-config will properly complain, if there will be something wrong).
        Hide
        Timothy Bish added a comment -

        applied the fix for the activemq-config file. It doesn't look like the apr / apu patch would play nice with the --with-apr and --with-apr-util way of using nonstandard APR installations.

        Show
        Timothy Bish added a comment - applied the fix for the activemq-config file. It doesn't look like the apr / apu patch would play nice with the --with-apr and --with-apr-util way of using nonstandard APR installations.
        František Dvořák made changes -
        Field Original Value New Value
        Attachment apr-devel.diff [ 12539566 ]
        Hide
        František Dvořák added a comment -

        Add flags and includes to activemq-cpp.pc and activemq-config files.

        Show
        František Dvořák added a comment - Add flags and includes to activemq-cpp.pc and activemq-config files.
        František Dvořák created issue -

          People

          • Assignee:
            Timothy Bish
            Reporter:
            František Dvořák
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development