[AMQCPP-352] FailoverTransportFactory doesn't work correctly with more than two composite uris

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0, 3.2.4
• Fix Version/s: 3.2.5, 3.3.0
• Component/s: Transports

Environment

All platforms

• Assignee: Timothy A. Bish
• Reporter: Dmitry Babich
• Created: 27/Feb/11 18:30
• Updated: 28/Feb/11 14:18
• Resolved: 28/Feb/11 14:18

Description

Only first and last composite uris are recognized by FailoverTransportFactory.

For example - given uri:
failover://(tcp://10.10.10.1:61616,tcp://10.10.10.2:61616,tcp://10.10.10.3:61616,tcp://10.10.10.4:61616)
only "tcp://10.10.10.1:61616" and "tcp://10.10.10.4:61616" will work.

The bug in URISupport::splitComponents().
Line 350:
std::string s = str.substr( last, i );
should be replaced by:
std::string s = str.substr( last, i - last ); // 2nd argument of substr() is length of substring