Details
-
Bug
-
Status: Resolved
-
Minor
-
Resolution: Fixed
-
None
-
None
-
Regression
Description
commons-lang3 was removed in this commit for AMQ-8572 which breaks the console since it still uses org.apache.commons.lang3.StringEscapeUtils.escapeHtml4 and org.apache.commons.lang3.StringEscapeUtils.escapeEcmaScript. This commit was merged in to the main branch in October before the 5.17.3 release however it seems it was never merged in to the 5.17.x branch so the 5.17.3 console should still be fine!
We should either revert that commit or find a different way to escape the text.
WARN | /admin/send.jsp javax.servlet.ServletException: javax.servlet.ServletException: org.apache.jasper.JasperException: Unable to compile class for JSP: An error occurred at line: [27] in the jsp file: [/WEB-INF/tags/form/text.tag] org.apache.commons.lang3.StringEscapeUtils cannot be resolved to a type 24: if (value == null) { 25: value = ""; 26: } 27: value = org.apache.commons.lang3.StringEscapeUtils.escapeHtml4(value); 28: 29: %> 30: <input type="text" name="${name}" value="<%= value %>"/> Stacktrace: at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:162) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.server.Server.handle(Server.java:516) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:487) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:732) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:479) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311) ~[jetty-io-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105) ~[jetty-io-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104) ~[jetty-io-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:883) ~[jetty-util-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1034) ~[jetty-util-9.4.49.v20220914.jar:9.4.49.v20220914] at java.lang.Thread.run(Thread.java:1589) ~[?:?] Caused by: javax.servlet.ServletException: org.apache.jasper.JasperException: Unable to compile class for JSP: An error occurred at line: [27] in the jsp file: [/WEB-INF/tags/form/text.tag] org.apache.commons.lang3.StringEscapeUtils cannot be resolved to a type 24: if (value == null) { 25: value = ""; 26: } 27: value = org.apache.commons.lang3.StringEscapeUtils.escapeHtml4(value); 28: 29: %> 30: <input type="text" name="${name}" value="<%= value %>"/> Stacktrace: at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:162) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:560) ~[jetty-security-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:146) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] ... 12 more Caused by: org.apache.jasper.JasperException: Unable to compile class for JSP: An error occurred at line: [27] in the jsp file: [/WEB-INF/tags/form/text.tag] org.apache.commons.lang3.StringEscapeUtils cannot be resolved to a type 24: if (value == null) { 25: value = ""; 26: } 27: value = org.apache.commons.lang3.StringEscapeUtils.escapeHtml4(value); 28: 29: %> 30: <input type="text" name="${name}" value="<%= value %>"/> Stacktrace: at org.apache.jasper.compiler.DefaultErrorHandler.javacError(DefaultErrorHandler.java:101) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.compiler.ErrorDispatcher.javacError(ErrorDispatcher.java:213) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:556) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.compiler.Compiler.compile(Compiler.java:380) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.compiler.Compiler.compile(Compiler.java:350) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.compiler.Compiler.compile(Compiler.java:334) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:597) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.servlet.JspServletWrapper.loadTagFile(JspServletWrapper.java:268) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.compiler.TagFileProcessor.loadTagFile(TagFileProcessor.java:588) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.compiler.TagFileProcessor.access$000(TagFileProcessor.java:49) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.compiler.TagFileProcessor$TagFileLoaderVisitor.visit(TagFileProcessor.java:671) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.compiler.Node$CustomTag.accept(Node.java:1558) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2385) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2437) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.compiler.Node$Visitor.visit(Node.java:2443) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.compiler.Node$Root.accept(Node.java:471) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2385) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.compiler.TagFileProcessor.loadTagFiles(TagFileProcessor.java:694) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:232) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.compiler.Compiler.compile(Compiler.java:374) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.compiler.Compiler.compile(Compiler.java:350) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.compiler.Compiler.compile(Compiler.java:334) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:597) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:398) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:383) ~[apache-jsp-8.5.70.jar:8.5.70] at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:331) ~[apache-jsp-8.5.70.jar:8.5.70] at org.eclipse.jetty.jsp.JettyJspServlet.service(JettyJspServlet.java:106) ~[apache-jsp-9.4.49.v20220914.jar:9.4.49.v20220914] at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) ~[tomcat-servlet-api-9.0.65.jar:4.0.FR] at org.eclipse.jetty.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1459) ~[jetty-servlet-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799) ~[jetty-servlet-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1656) ~[jetty-servlet-9.4.49.v20220914.jar:9.4.49.v20220914] at org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:100) ~[spring-web-5.3.23.jar:5.3.23] at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117) ~[spring-web-5.3.23.jar:5.3.23] at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193) ~[jetty-servlet-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626) ~[jetty-servlet-9.4.49.v20220914.jar:9.4.49.v20220914] at org.apache.activemq.web.SessionFilter.doFilter(SessionFilter.java:45) ~[activemq-web-5.18.0-SNAPSHOT.jar:5.18.0-SNAPSHOT] at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193) ~[jetty-servlet-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626) ~[jetty-servlet-9.4.49.v20220914.jar:9.4.49.v20220914] at org.apache.activemq.web.filter.ApplicationContextFilter.doFilter(ApplicationContextFilter.java:102) ~[?:?] at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:201) ~[jetty-servlet-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626) ~[jetty-servlet-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:552) ~[jetty-servlet-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:560) ~[jetty-security-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1440) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:505) ~[jetty-servlet-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1355) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:146) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:560) ~[jetty-security-9.4.49.v20220914.jar:9.4.49.v20220914] at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:146) ~[jetty-server-9.4.49.v20220914.jar:9.4.49.v20220914] ... 12 more
