[AMQ-8583] Move class ResponseHandler into package protocol - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 5.17.0
Fix Version/s: 5.17.1, 5.18.0
Component/s: AMQP
Labels:
None

Description

Issue Description

Package org.apache.activemq.transport.amqp is a promiscuous package, and groups together miscellaneous functionalities that might be useful to different subsystems. This means the cohesion between classes in the package is low. However, since the project has grown larger, this package structure is becoming increasingly hard to navigate. We found that Class ResponseHandler is not used by classes in their package org.apache.activemq.transport.amqp. Moreover, there are a lot of dependencies between class ResponseHandler and classes in the package org.apache.activemq.transport.amqp.protocol.

Location: The source file can be found at path File /activemq-amqp/src/main/java/org/apache/activemq/transport/amqp/ResponseHandler.java

Refactoring suggestions

To avoid making org.apache.activemq.transport.amqp too big and unmanageable, we suggest to move class ResponseHandler into package org.apache.activemq.transport.amqp.protocol.