Uploaded image for project: 'ActiveMQ Classic'
  1. ActiveMQ Classic
  2. AMQ-8583

Move class ResponseHandler into package protocol

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 5.17.0
    • 5.17.1, 5.18.0
    • AMQP
    • None

    Description

      Issue Description

       

      Package org.apache.activemq.transport.amqp is a promiscuous package, and groups together miscellaneous functionalities that might be useful to different subsystems. This means the cohesion between classes in the package is low. However, since the project has grown larger, this package structure is becoming increasingly hard to navigate. We found that Class ResponseHandler is not used by classes in their package org.apache.activemq.transport.amqp. Moreover, there are a lot of dependencies between class ResponseHandler and classes in the package org.apache.activemq.transport.amqp.protocol.

      Location: The source file can be found at path File /activemq-amqp/src/main/java/org/apache/activemq/transport/amqp/ResponseHandler.java

      Refactoring suggestions

       

      To avoid making org.apache.activemq.transport.amqp too big and unmanageable, we suggest to move class ResponseHandler into package org.apache.activemq.transport.amqp.protocol.

       

      Attachments

        Issue Links

          Activity

            People

              jbonofre Jean-Baptiste Onofré
              Fanyi Fanyi
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 10m
                  10m