[AMQ-8253] Unnecessary stack trace in case of invalid STOMP version

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.16.2
• Fix Version/s: 5.16.4, 5.17.0

Environment

ActiveMQ 5.16.2

• Assignee: Jean-Baptiste Onofré
• Reporter: Lionel Cons
• Created: 28/Apr/21 07:42
• Updated: 15/Jan/22 05:46
• Resolved: 15/Jan/22 05:46

Description

In case of an invalid STOMP version used, we get an unnecessary stack trace:

2021-04-28T09:17:07.004+0200 [ActiveMQ NIO Worker 0] WARN Transport - Transport Connection to: tcp://10.0.0.1:50938 failed
org.apache.activemq.transport.stomp.ProtocolException: Invalid Protocol version[3.14], supported versions are: [1.2, 1.1, 1.0]
	at org.apache.activemq.transport.stomp.StompCodec.detectVersion(StompCodec.java:151)
	at org.apache.activemq.transport.stomp.ProtocolConverter.onStompConnect(ProtocolConverter.java:760)
	at org.apache.activemq.transport.stomp.ProtocolConverter.onStompCommand(ProtocolConverter.java:254)
	at org.apache.activemq.transport.stomp.StompTransportFilter.onCommand(StompTransportFilter.java:85)
	at org.apache.activemq.transport.TransportSupport.doConsume(TransportSupport.java:83)
	at org.apache.activemq.transport.stomp.StompCodec.processCommand(StompCodec.java:133)
	at org.apache.activemq.transport.stomp.StompCodec.parse(StompCodec.java:100)
	at org.apache.activemq.transport.stomp.StompNIOTransport.processBuffer(StompNIOTransport.java:136)
	at org.apache.activemq.transport.stomp.StompNIOTransport.serviceRead(StompNIOTransport.java:121)
	at org.apache.activemq.transport.stomp.StompNIOTransport.access$000(StompNIOTransport.java:44)
	at org.apache.activemq.transport.stomp.StompNIOTransport$1.onSelect(StompNIOTransport.java:73)
	at org.apache.activemq.transport.nio.SelectorSelection.onSelect(SelectorSelection.java:98)
	at org.apache.activemq.transport.nio.SelectorWorker$1.run(SelectorWorker.java:123)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

This looks very similar to AMQ-8252.

Issue Links

• is duplicated by: AMQ-8252 Unnecessary stack trace in case of invalid credentials
• is related to: AMQ-8252 Unnecessary stack trace in case of invalid credentials