[AMQ-7407] Partitioning by queue/topic chooses incorrect target

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.16.0, 5.15.12
• Assignee: Jean-Baptiste Onofré
• Reporter: Maksym Brodin
• Created: 17/Feb/20 20:24
• Updated: 28/Feb/20 06:33
• Resolved: 28/Feb/20 06:33

Description

This code always returns the latest target, instead of the best target (with the largest score)

https://github.com/apache/activemq/blob/master/activemq-partition/src/main/java/org/apache/activemq/partition/PartitionBroker.java#L251

 

// The target with largest score wins..            
if( !targetScores.isEmpty() ) {                
   Target bestTarget = null;                
   int bestScore=0;                
   for (Map.Entry<Target, Score> entry : targetScores.entrySet()) {
     if( entry.getValue().value > bestScore ) {
        bestTarget = entry.getKey();                    
     }
   }
   return bestTarget;
}

Issue Links

• links to: GitHub Pull Request #482