[AMQ-7298] failover duplicate detection in error with batched local transactions

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.15.0
• Fix Version/s: 5.16.0, 5.17.0
• Component/s: JMS client
• Assignee: Gary Tully
• Reporter: Gary Tully
• Created: 04/Sep/19 11:14
• Updated: 21/Apr/21 05:29
• Resolved: 04/Sep/19 11:30

Description

Messages can get poisonAcked in error as duplicate deliveries when a local transaction rollback during/after a failover (auto reconnect) event.
The interaction between rollback and failover redelivery has a bunch of timing issues and did create duplicates in-error that resulted in over eager suppression.
There are a bunch of related tests that validate expected behaviour, the related fixes needed to be revisited to better manage the delivered and unconsumed messages in the context of a local transaction and to avoid the real duplication of delivery in the client.
There is an additional new test that demonstrates the additional dlq or duplicates behaviour.

a nice cross section from the unit test suite is:
mvn clean install -Dtest=CloseRollbackRedeliveryQueueTest,AMQ2149Test,JMSQueueRedeliverTest,RedeliveryPolicyTest,FailoverTransactionTest,FailoverDurableSubTransactionTest,JMSConsumerTest,JmsSessionRecoverTest,AMQ2751Test

Issue Links

• is related to: AMQ-8168 Server-side redelivery no longer working with 5.16.1
• supercedes: AMQ-2751 session.recover does not result in repeated redelivery - duplicate is detected and auto-acked in error