[AMQ-7052] Fix tests related to purgeRecoveredXATransactions property on the KahaDB

• Type: Test
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.15.5, 5.15.6
• Fix Version/s: 5.16.0
• Component/s: Test Cases
• Patch Info: Patch Available
• Assignee: Gary Tully
• Reporter: Alan Protasio
• Created: 14/Sep/18 08:35
• Updated: 23/Mar/21 14:23
• Resolved: 18/Sep/18 09:42

Description

Fix the following tests:

JdbcXARecoveryBrokerTest>CombinationTestSupport.runBare:107->XARecoveryBrokerTest.testPreparedTransactionRecoveredPurgeRollbackOnRestart:332 expected:<0> but was:<4>

JdbcXARecoveryBrokerTest>CombinationTestSupport.runBare:107->XARecoveryBrokerTest.testPreparedTransactionRecoveredPurgeCommitOnRestart:391 null

mKahaDBXARecoveryBrokerTest>CombinationTestSupport.runBare:107->XARecoveryBrokerTest.testPreparedTransactionRecoveredPurgeRollbackOnRestart:332 expected:<0> but was:<4>

mKahaDBXARecoveryBrokerTest>CombinationTestSupport.runBare:107->XARecoveryBrokerTest.testPreparedTransactionRecoveredPurgeCommitOnRestart:391 null

mLevelDBXARecoveryBrokerTest>CombinationTestSupport.runBare:107->XARecoveryBrokerTest.testPreparedTransactionRecoveredPurgeRollbackOnRestart:332 expected:<0> but was:<4>

Those tests are failing because this feature (purge transactions after reboot) was only implemented on the KahaDBPersistenceAdapter.

https://github.com/apache/activemq/commit/ce7498c971b99e2515f07aab36418a1a0f19c03e

The tests are failing because the class XARecoveryBrokerTest is used to test multiples adapters that are not implementing the same feature.

Steps to reproduce:

> git checkout https://github.com/apache/activemq/tree/activemq-5.15.x

> cd activemq-unit-tests

> mvn clean install -Dtest=JdbcXARecoveryBrokerTest

 

Issue Links

• is broken by: AMQ-7015 Startup performance improvement when log contains prepared transactions.
• links to: GitHub Pull Request #298