[AMQ-6942] Shell script stop command does not work if PS_FORMAT is redefined

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 5.15.3
• Component/s: Command Line Tools

Environment

Not sure this is relevant. The problem describe occurs because PS_FORMAT is redefined on the specific machines I am using activemq.

% cat /etc/lsb-release
DISTRIB_ID=LinuxMint
DISTRIB_RELEASE=17.2
DISTRIB_CODENAME=rafaela
DISTRIB_DESCRIPTION="Linux Mint 17.2 Rafaela"

• Assignee: Unassigned
• Reporter: Harald Kirsch
• Created: 31/Mar/18 12:41
• Updated: 22/Jul/18 11:28

Description

In the command line tool activemq, line 387 reads

RET="`ps -p "${ACTIVEMQ_PID}"|grep java`"

This does not work if PS_FORMAT is redefined. A fix would be to unset PS_FORMAT just before running this line. I just wonder whether this kind of test is sensible anyway. It seems to be an attempt to make sure not to kill a process that by accident acquired the same pid long after activemq was killed. Yet testing for java is no guarantee either.

Depending on what the expectation on stability on ill-defined Linux/Unix-environments is, one could argue that PS_FORMAT should not be messed with. But then it would be good if at least the API-shutdown is tried first and only the kill is not performed if the above grep fails.