Uploaded image for project: 'ActiveMQ Classic'
  1. ActiveMQ Classic
  2. AMQ-6698

auto+nio+ssl protocolDetectionTimeout does not work if SSL handshake is not finished

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 5.14.5
    • 5.15.0, 5.14.6
    • Broker, Transport
    • None

    Description

      The protocolDetectionTimeout value is supposed to define how long a connection attempt has to detect the protocol type before failing. However there is a small issue where the initial SSL handshake is being done outside of the async task that times out. This means that if the SSL handshake isn't finished because the client never sends enough bytes (such as if a client opens a normal TCP socket) then the socket will just hang open and not be closed. The handshake should be moved inside of the task that times out to fix this.

      Also, I'm going to change the default protocolDetectionTimeout to 30 seconds instead of 15 seconds as 30 is the default for the TcpTransport connectionTimeout value and also the default for the InactivityMonitor.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            cshannon Christopher L. Shannon
            cshannon Christopher L. Shannon
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment