Uploaded image for project: 'ActiveMQ'
  1. ActiveMQ
  2. AMQ-6431

BitArrayBin doesn't work well with index larger than Integer.MAX_VALUE

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.14.0
    • Fix Version/s: 5.14.1, 5.15.0
    • Component/s: JMS client
    • Labels:
      None

      Description

      I have a problem with "messageid deplicate". Then I found it's a bug(AMQ-5016) in activemq5.9.0 , so I download the activemq5.14.0. I run the BitArrayBinTest.java:

       public static void main(String[] args) {
             BitArrayBin toTest = new BitArrayBin(1024);
             long largeNum = Integer.MAX_VALUE*2L +100L;
             toTest.setBit(largeNum, true);
             System.out.println(toTest.getBit(largeNum));   
      }
      

      I expect the results to be "true",but the result of running the above code is "false".
      I debug the code,and I found a method 'getBin(long index)' in class BitArrayBin. Code as follows:

      private int getBin(long index) {
              int answer = 0;
              if (longFirstIndex < 0) {
                  longFirstIndex = (int) (index - (index % BitArray.LONG_SIZE));
              } else if (longFirstIndex >= 0) {
                  answer = (int)((index - longFirstIndex) / BitArray.LONG_SIZE);
              }
              return answer;
          }
      

      I think the problem is in code ‘longFirstIndex = (int) (index - (index % BitArray.LONG_SIZE))‘. When index is larger than Integer.MAX_VALUE, longFirstIndex will be negative. I think this line of code should be modified to ‘longFirstIndex = (long) (index - (index % BitArray.LONG_SIZE));’

        Attachments

        1. BitArrayBinTest.java
          0.5 kB
          wangqinghuan

          Activity

            People

            • Assignee:
              cshannon Christopher L. Shannon
              Reporter:
              wangqinghuan wangqinghuan
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: