Uploaded image for project: 'ActiveMQ'
  1. ActiveMQ
  2. AMQ-6431

BitArrayBin doesn't work well with index larger than Integer.MAX_VALUE

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 5.14.0
    • 5.14.1, 5.15.0
    • JMS client
    • None

    Description

      I have a problem with "messageid deplicate". Then I found it's a bug(AMQ-5016) in activemq5.9.0 , so I download the activemq5.14.0. I run the BitArrayBinTest.java:

       public static void main(String[] args) {
             BitArrayBin toTest = new BitArrayBin(1024);
             long largeNum = Integer.MAX_VALUE*2L +100L;
             toTest.setBit(largeNum, true);
             System.out.println(toTest.getBit(largeNum));   
      }
      

      I expect the results to be "true",but the result of running the above code is "false".
      I debug the code,and I found a method 'getBin(long index)' in class BitArrayBin. Code as follows:

      private int getBin(long index) {
              int answer = 0;
              if (longFirstIndex < 0) {
                  longFirstIndex = (int) (index - (index % BitArray.LONG_SIZE));
              } else if (longFirstIndex >= 0) {
                  answer = (int)((index - longFirstIndex) / BitArray.LONG_SIZE);
              }
              return answer;
          }
      

      I think the problem is in code ‘longFirstIndex = (int) (index - (index % BitArray.LONG_SIZE))‘. When index is larger than Integer.MAX_VALUE, longFirstIndex will be negative. I think this line of code should be modified to ‘longFirstIndex = (long) (index - (index % BitArray.LONG_SIZE));’

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            cshannon Christopher L. Shannon
            wangqinghuan qinghuan wang
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment