[AMQ-6399] Log a warning when starting a networkConnector with static:failover without using maxReconnectAttempts=0

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Abandoned
• Affects Version/s: 5.0.0
• Fix Version/s: AGING_TO_DIE
• Component/s: Broker
• Labels: close-pending
• Assignee: Matt Pavlovich
• Reporter: Tim Bain
• Created: 18/Aug/16 04:01
• Updated: 15/Jan/21 15:42
• Resolved: 15/Jan/21 15:42

Description

When configuring a networkConnector using the static:failover: transport, you'll be unable to failover if you don't specify the maxReconnectAttempts=0 option on the failover transport.

We periodically see users on the mailing list getting tripped up by this, since it's not intuitive or obvious. One option would be to simply refuse to start the broker when this happens (since there probably isn't a valid reason to configure a networkConnector that way), but since that's probably too draconian, we should instead log a warning that tells the user that this is probably not what they want so they can fix it.