[AMQ-6086] Broker stop and start are not at all thread safe - we can do better

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.13.0
• Fix Version/s: 5.13.1, 5.14.0
• Component/s: Broker
• Assignee: Gary Tully
• Reporter: Gary Tully
• Created: 11/Dec/15 16:17
• Updated: 25/Sep/18 15:29
• Resolved: 11/Dec/15 16:25

Description

If one thread starts a broker and a second tries to stop we can get in a mess. Particularly if there is blocking or locking in the mix. In some cases we are ok but there is no determinism.
In a simple case, the stop can complete before the start gets going at all and we miss the stop, leaving a dangling broker.