[AMQ-6083] Broker starts on corrupted kahadb despite checkForCorruptJournalFiles="true" and ignoreMissingJournalfiles="false"

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.13.0
• Fix Version/s: 5.13.1, 5.14.0
• Component/s: KahaDB
• Assignee: Gary Tully
• Reporter: Gary Tully
• Created: 09/Dec/15 12:13
• Updated: 11/Dec/15 14:53
• Resolved: 09/Dec/15 12:38

Description

Kahadb checkForCorruptJournaFiles will pick up journal corruption via the checksum, but if the corrupt locations are not referenced by the index the corruption is ignored, even if ignoreMissingJournalFiles (which should be called ignoreMissingJournalFilesOrCorruptJournalLocations) is false (the default).

this means that acks can be missing and in the event of a journal replay, there is no indication of the missing acks.

If ignoreMissingJournalFiles=false and corruption or missing journal files that just have acks are detected, the broker should error out.

This ensures that corruption does not go unnoticed and the root cause can be determined before restart.