[AMQ-6034] The StompConnection class contains incorrect STOMP code

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: STOMP
• Labels: close-pending
• Assignee: Matt Pavlovich
• Reporter: Lionel Cons
• Created: 04/Nov/15 12:26
• Updated: 03/Mar/21 17:28

Description

The org.apache.activemq.transport.stomp.StompConnection class contains incorrect code related to STOMP frame handling.

On the receiving side, receive() uses StompWireFormat which is correct. However, the class also contains receiveFrame() which is not correct.

On the sending side, most related methods use the StompFrame.format() method which is not correct, StompWireFormat.marshal() should be used instead.

So, StompWireFormat should be used in all the marshal/unmarshal operations and equivalent code should be removed from the related classes like StompConnection.