[AMQ-6004] TcpTransportServer#socketHandlerThread should be intterrupted to stop the socket handler (daemon) thread

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.12.0
• Fix Version/s: 5.12.1, 5.13.0
• Patch Info: Patch Available
• Assignee: Christopher L. Shannon
• Reporter: Erik Godding Boye
• Created: 08/Oct/15 09:25
• Updated: 18/Nov/15 16:21
• Resolved: 08/Oct/15 12:15

Description

I am trying to achieve a clean shutdown of an embedded broker in a web application running in Tomcat. When the web application is shut down, Tomcat is always complaining about a running thread:

09:09:55.948 WARN  [o.a.c.loader.WebappClassLoaderBase] [] The web application [xxx] appears to have started a thread named [ActiveMQ Transport Server Thread Handler: tcp://0.0.0.0:12345] but has failed to stop it. This is very likely to create a memory leak. Stack trace of thread:
 sun.misc.Unsafe.park(Native Method)
 java.util.concurrent.locks.LockSupport.parkNanos(Unknown Source)
 java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(Unknown Source)
 java.util.concurrent.LinkedBlockingQueue.poll(Unknown Source)
 org.apache.activemq.transport.tcp.TcpTransportServer$2.run(TcpTransportServer.java:427)
 java.lang.Thread.run(Unknown Source)

I am pretty sure this can be easily fixed by interrupting the socket handler thread, as suggested by Andreas Hartmann in AMQ-3451. Please see attached patch.