[AMQ-5990] PooledConnectionFactory does not allow disabling JMX on GenericKeyObjectPool

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.12.1, 5.13.0
• Patch Info: Patch Available
• Flags: Patch, Important
• Assignee: Christopher L. Shannon
• Reporter: Aravind Chennuru
• Created: 30/Sep/15 17:29
• Updated: 08/Oct/15 12:02
• Resolved: 01/Oct/15 18:14

Description

initConnectionPool does not allow us to configure the GenericKeyObjectPool.
Suggestion:
PooledConnectionFactory

private GenericKeyedObjectPoolConfig config;
public void setBasePoolConfig(final GenericKeyedObjectPoolConfig config) {
        this.config = config;
}

public void initConnectionsPool() {
     if (this.connectionsPool == null) {
            this.connectionsPool = new GenericKeyedObjectPool<ConnectionKey, ConnectionPool>(blah, config==null?new GenericKeyedObjectPoolConfig():config);
     }
}

protected ConnectionPool createConnectionPool(Connection connection) {
        return new ConnectionPool(connection, config);
    }

ConnectionPool

public ConnectionPool(Connection connection) {
      this(connection, new GenericKeyedObjectPoolConfig());
}

public ConnectionPool(Connection connection, GenericKeyedObjectPoolConfig config) {
      this.connection = wrap(connection);
      this.sessionPool = new GenericKeyedObjectPool<SessionKey, SessionHolder>(blah, config==null?new GenericKeyedObjectPoolConfig():config);
}