[AMQ-5876] improve performance of TextFileCertificateLoginModule when many entries are in the "textfiledn.user " file

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.11.1
• Fix Version/s: 5.12.0
• Component/s: Security/JAAS
• Labels: jaas
• Assignee: Gary Tully
• Reporter: Gary Tully
• Created: 08/Jul/15 10:55
• Updated: 02/Nov/19 05:36
• Resolved: 08/Jul/15 11:22

Description

With a large number of entries ( 200,000 ) in the "org.apache.activemq.jaas.textfiledn.user" file the performance seemed to degrade.

To demonstrate the performance difference;

1) for 100 entries and calling initialize,login(),commit 10 times - Time taken is 73 miliseconds

2) for 200,000 entries and calling initialize,login(),commit 10 times - Time taken is  5020 miliseconds

Suggested improvements:

• avoid loading the org.apache.activemq.jaas.textfiledn.user file each time - in PropertiesLoginModule.java, the file is only read when it changes, using the file modification time.

• avoid iterating through the Properties object, using a Map instead to retrieve the userName

Issue Links

• is part of: ARTEMIS-299 Improve performance of TextFileCertificateLoginModule when many entries in user file
• is related to: AMQ-912 ActiveMQ support for SSL authentication and authorization