[AMQ-5710] ActiveMQConnection cleanup should not close the connection on the broker

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.11.0
• Fix Version/s: 5.12.0
• Assignee: Dejan Bosanac
• Reporter: Dejan Bosanac
• Created: 07/Apr/15 15:19
• Updated: 07/Apr/15 15:25
• Resolved: 07/Apr/15 15:25

Description

As the spec says

http://docs.oracle.com/javaee/6/api/javax/resource/spi/ManagedConnection.html#cleanup()

"The cleanup of ManagedConnection instance resets its client specific state and prepares the connection to be put back in to a connection pool. The cleanup method should not cause resource adapter to close the physical pipe and reclaim system resources associated with the physical connection."

We should not send RemoveInfo on cleanup, but just clean client side state. The result of "closing" a connection on cleanup is that connection will not be cached when using XA transactions, causing high CPU usage on the broker.