[AMQ-5692] Inactivity monitor does not time out on stuck socket writes

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Abandoned
• Affects Version/s: 5.11.1
• Component/s: Broker
• Labels: broker inactivity
• Assignee: Unassigned
• Reporter: Torsten Mielke
• Created: 27/Mar/15 13:00
• Updated: 13/Mar/22 14:16
• Resolved: 13/Mar/22 14:16

Description

It is possible that a socket write is stuck but the inactivity monitor currently does not time out on a socketWrite.

AbstractInactivityMonitor.java

    final void writeCheck() {
        if (inSend.get()) {
            LOG.trace("Send in progress. Skipping write check.");
            return;
        }

As a result a connection that is stuck in a tcp write will never be taken down due to inactivity. If a client misbehaves the broker will not be able to clear that connection as part of the inactivity monitoring.

Now AMQ-2511 introduced a counter on the reachCheck() to detect it a socket read in progress really retrieves data or is stuck.
I propose for a similar mechanism being applied on the writeCheck() operation so that a socket write that is stuck can be detected and the connection can be closed.