[AMQ-5686] ProxyMessageStore doesn't properly delegate

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.11.1
• Fix Version/s: 5.12.0
• Component/s: Broker
• Labels: easyfix
• Assignee: Timothy A. Bish
• Reporter: Christopher L. Shannon
• Created: 24/Mar/15 19:47
• Updated: 25/Mar/15 14:27
• Resolved: 24/Mar/15 20:08

Description

In ProxyMessageStore the method asyncAddTopicMessage does not call the delegate method as it should. This causes a StackOverflowError if the method is called as it will just recursively keep calling the same method over and over again.

The problem is here on line 141 of ProxyMessageStore.java:

@Override
public ListenableFuture<Object> asyncAddTopicMessage(ConnectionContext context, Message message, boolean canOptimizeHint) throws IOException {
  return asyncAddTopicMessage(context,message,canOptimizeHint);
}

This simply should be changed to:

@Override
public ListenableFuture<Object> asyncAddTopicMessage(ConnectionContext context, Message message, boolean canOptimizeHint) throws IOException {
  return delegate.asyncAddTopicMessage(context,message,canOptimizeHint);
}