Uploaded image for project: 'ActiveMQ Classic'
  1. ActiveMQ Classic
  2. AMQ-5591 AMQP Implement the JMS Mapping spec as it evolves.
  3. AMQ-5604

AMQP: Clean up unit test start / stop code, excessive thread creation casuse slowdowns.

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 5.11.0, 5.11.1
    • 5.12.0
    • AMQP
    • None

    Description

      The current test support code uses single thread executor instances as defense against hangs on test tearDown but is a bit aggressive with it as it also does Broker start / stop in an executor and never reuses them so every test run requires three to four threads just to start stop. There's also some thread interruption bits that blindly interrupt anything that is not the main thread which could lead to problems with the JUnit threads etc. We can reduce this all down to one executor to close the legacy QPid JMS client connection which does sometimes hang on close.

      This shaves off anywhere from 1.5 to 2 minutes from the test run.

      Attachments

        Activity

          People

            tabish Timothy A. Bish
            tabish Timothy A. Bish
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: