[AMQ-5580] Thread unsafe operations on the PersistenceAdapters in the mKahaDB implementation

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.10.0, 5.10.1, 5.11.0
• Fix Version/s: 5.11.1, 5.12.0
• Component/s: Message Store
• Assignee: Timothy A. Bish
• Reporter: Timothy A. Bish
• Created: 11/Feb/15 21:34
• Updated: 13/Feb/15 18:22
• Resolved: 11/Feb/15 22:22

Description

The MultiKahaDBPersistenceAdapter stores the list of PersistenceAdapters in a LinkedList and does not guard against concurrent read / write operations which can lead to exceptions in the logs and possible other subtle issues due to the fact that traversal can be interrupted. The simple solution is to use a CopyOnWriteArrayList here as this list is only added to and the set of adapters is generally not very large. This will prevent an errors during iterations over the set of adapters.