[AMQ-5473] Race condition caused by Linkstealing might make durable subs inactive

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.11.0
• Fix Version/s: 5.11.0
• Component/s: Broker
• Patch Info: Patch Available
• Assignee: Timothy A. Bish
• Reporter: AR
• Created: 03/Dec/14 18:12
• Updated: 09/Dec/14 16:00
• Resolved: 09/Dec/14 15:36

Description

Link Stealing creates a new connection and disconnects the old connection. These operations are done concurrently.
New connection triggers addConsumer() for active subscriptions and old connection stop causes removeConsumer() for the same.

Problems:

• addConsumer() would throw exception that the sub is already active (if remove did not happen before)
• even if we go past the exception, it will not set the right (new) connection context and consumer info the subs
• removeConsumer() may remove subcription even if it had different connection context (created by linkstealing)

Patch attached.

Issue Links

• is duplicated by: AMQ-5428 Durable Subscriptions are not being setup while link stealing is happening