Uploaded image for project: 'ActiveMQ Classic'
  1. ActiveMQ Classic
  2. AMQ-5591 AMQP Implement the JMS Mapping spec as it evolves.
  3. AMQ-5470

AMQP - delayed authentication from SASL connect leads to race on client end.

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 5.10.0
    • 5.12.0
    • AMQP
    • None

    Description

      We currently delay checking the credentials provided during the SASL negotiation and also checking if anonymous client connects are legal until after opening the proton connection and then we send an error condition indicating the failure and close the connection. This can lead to a race on the client end where it looks for a breif moment in time that the connection succeeded. During that time the client might attempt some further action and then fail in an odd way as the connection is closed under it.

      We should look into authenticating immediately and failing the SASL handshake if not authorized. We should also consider whether we want to support raw connections with a SASL handshake as well since without at least a SASL ANONYMOUS handshake we can get back into this issue unless we just forcibly close the socket on a client if we don't support anonymous connections.

      Attachments

        1. AMQ-5470.patch
          20 kB
          Timothy A. Bish

        Activity

          People

            tabish Timothy A. Bish
            tabish Timothy A. Bish
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: