[AMQ-5462] dead code in method createSession of class ActiveMQConnection

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.8.0, 5.9.0, 5.9.1, 5.10.0
• Fix Version/s: 5.14.0
• Component/s: JMS client

Environment

64bit win7+64bit jdk1.7.0_72

• Assignee: Unassigned
• Reporter: can_do
• Created: 28/Nov/14 06:18
• Updated: 12/Apr/16 23:33
• Resolved: 12/Apr/16 23:33

Description

org.apache.activemq.ActiveMQConnection ==>
in method "public Session createSession(boolean transacted, int acknowledgeMode) throws JMSException"

in statement [return new EMQSession ... ]
code [acknowledgeMode == Session.SESSION_TRANSACTED] is dead.
because this condition has been decided in method entrance.
Futhermore when using tranaction,the acknowledge mode must be 0.
This is right or not?