[AMQ-5312] activemq-pool - Should not log expired connection when the pool is stopped as that causes log floods during shutdown

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.10.0
• Fix Version/s: 5.11.0
• Component/s: Pool
• Assignee: Claus Ibsen
• Reporter: Claus Ibsen
• Created: 07/Aug/14 12:32
• Updated: 07/Aug/14 13:07
• Resolved: 07/Aug/14 13:07

Description

If you shutdown amq client + pool and whatnot, then you may get excessive logs about expired connections, as they are logged at INFO level.

Example

2014-08-07 14:23:42,572 [est-broker-2#16] INFO  PooledConnectionFactory        - Expiring connection ActiveMQConnection {id=ID:davsclaus.air-50586-1407414219217-5:1,clientId=ID:davsclaus.air-50586-1407414219217-4:1,started=false} on IOException: org.apache.activemq.transport.TransportDisposedIOException: peer (vm://test-broker-2#17) stopped.
2014-08-07 14:23:42,575 [est-broker-3#32] INFO  PooledConnectionFactory        - Expiring connection ActiveMQConnection {id=ID:davsclaus.air-50586-1407414219217-7:1,clientId=ID:davsclaus.air-50586-1407414219217-6:1,started=false} on IOException: org.apache.activemq.transport.TransportDisposedIOException: peer (vm://test-broker-3#33) stopped.
2014-08-07 14:23:42,575 [test-broker-1#4] INFO  PooledConnectionFactory        - Expiring connection ActiveMQConnection {id=ID:davsclaus.air-50586-1407414219217-3:3,clientId=ID:davsclaus.air-50586-1407414219217-2:3,started=false} on IOException: org.apache.activemq.transport.TransportDisposedIOException: peer (vm://test-broker-1#5) stopped.
2014-08-07 14:23:42,576 [test-broker-1#0] INFO  PooledConnectionFactory        - Expiring connection ActiveMQConnection {id=ID:davsclaus.air-50586-1407414219217-3:1,clientId=ID:davsclaus.air-50586-1407414219217-2:1,started=false} on IOException: org.apache.activemq.transport.TransportDisposedIOException: peer (vm://test-broker-1#1) stopped.
2014-08-07 14:23:42,577 [est-broker-2#18] INFO  PooledConnectionFactory        - Expiring connection ActiveMQConnection {id=ID:davsclaus.air-50586-1407414219217-5:2,clientId=ID:davsclaus.air-50586-1407414219217-4:2,started=false} on IOException: org.apache.activemq.transport.TransportDisposedIOException: peer (vm://test-broker-2#19) stopped.
2014-08-07 14:23:42,577 [est-broker-3#38] INFO  PooledConnectionFactory        - Expiring connection ActiveMQConnection {id=ID:davsclaus.air-50586-1407414219217-7:4,clientId=ID:davsclaus.air-50586-1407414219217-6:4,started=false} on IOException: org.apache.activemq.transport.TransportDisposedIOException: peer (vm://test-broker-3#39) stopped.
2014-08-07 14:23:42,578 [test-broker-1#6] INFO  PooledConnectionFactory        - Expiring connection ActiveMQConnection {id=ID:davsclaus.air-50586-1407414219217-3:4,clientId=ID:davsclaus.air-50586-1407414219217-2:4,started=false} on IOException: org.apache.activemq.transport.TransportDisposedIOException: peer (vm://test-broker-1#7) stopped.
2014-08-07 14:23:42,578 [est-broker-3#36] INFO  PooledConnectionFactory        - Expiring connection ActiveMQConnection {id=ID:davsclaus.air-50586-1407414219217-7:3,clientId=ID:davsclaus.air-50586-1407414219217-6:3,started=false} on IOException: org.apache.activemq.transport.TransportDisposedIOException: peer (vm://test-broker-3#37) stopped.
2014-08-07 14:23:42,579 [test-broker-1#2] INFO  PooledConnectionFactory        - Expiring connection ActiveMQConnection {id=ID:davsclaus.air-50586-1407414219217-3:2,clientId=ID:davsclaus.air-50586-1407414219217-2:2,started=false} on IOException: org.apache.activemq.transport.TransportDisposedIOException: peer (vm://test-broker-1#3) stopped.
2014-08-07 14:23:42,579 [test-broker-1#8] INFO  PooledConnectionFactory        - Expiring connection ActiveMQConnection {id=ID:davsclaus.air-50586-1407414219217-3:5,clientId=ID:davsclaus.air-50586-1407414219217-2:5,started=false} on IOException: org.apache.activemq.transport.TransportDisposedIOException: peer (vm://test-broker-1#9) stopped.
2014-08-07 14:23:42,579 [est-broker-3#34] INFO  PooledConnectionFactory        - Expiring connection ActiveMQConnection {id=ID:davsclaus.air-50586-1407414219217-7:2,clientId=ID:davsclaus.air-50586-1407414219217-6:2,started=false} on IOException: org.apache.activemq.transport.TransportDisposedIOException: peer (vm://test-broker-3#35) stopped.
2014-08-07 14:23:42,580 [est-broker-1#10] INFO  PooledConnectionFactory        - Expiring connection ActiveMQConnection {id=ID:davsclaus.air-50586-1407414219217-3:6,clientId=ID:davsclaus.air-50586-1407414219217-2:6,started=false} on IOException: org.apache.activemq.transport.TransportDisposedIOException: peer (vm://test-broker-1#11) stopped.
2014-08-07 14:23:42,581 [est-broker-2#20] INFO  PooledConnectionFactory        - Expiring connection ActiveMQConnection {id=ID:davsclaus.air-50586-1407414219217-5:3,clientId=ID:davsclaus.air-50586-1407414219217-4:3,started=false} on IOException: org.apache.activemq.transport.TransportDisposedIOException: peer (vm://test-broker-2#21) stopped.
2014-08-07 14:23:42,582 [est-broker-3#40] INFO  PooledConnectionFactory        - Expiring connection ActiveMQConnection {id=ID:davsclaus.air-50586-1407414219217-7:5,clientId=ID:davsclaus.air-50586-1407414219217-6:5,started=false} on IOException: org.apache.activemq.transport.TransportDisposedIOException: peer (vm://test-broker-3#41) stopped.
2014-08-07 14:23:42,582 [MQ ShutdownHook] INFO  TransportConnector             - Connector vm://test-broker-1 stopped

We should reduce this noise and only log if we are not stopped.