Uploaded image for project: 'ActiveMQ'
  1. ActiveMQ
  2. AMQ-5138

Useless code in VMTransport class

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.9.0
    • Fix Version/s: 5.10.0
    • Component/s: Broker
    • Labels:
      None

      Description

      In VMTransport class taskRunner is set to null two times needlessly on the next line and couple of lines below:
      taskRunner = null;
      messageQueue = null;

      if (mq != null)

      { mq.clear(); }

      // Allow pending deliveries to finish up, but don't wait
      // forever in case of an stalled onCommand.
      if (tr != null) {
      try

      { tr.shutdown(TimeUnit.SECONDS.toMillis(1)); }

      catch(Exception e) {
      }
      taskRunner = null;
      }

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              sdcf Yuriy Sidelnikov

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment