[AMQ-4645] The lease-database-locker does not work properly if slave broker system clock is behind Database server

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.8.0
• Fix Version/s: 5.9.0
• Component/s: Message Store
• Labels: clock jdbc lease masterSlave

Environment

jdbc master slave

• Assignee: Gary Tully
• Reporter: Gary Tully
• Created: 19/Jul/13 19:46
• Updated: 12/Nov/15 10:51
• Resolved: 22/Jul/13 12:12

Description

The lease locker can adjust the lease duration based on the DB current time but this only works if the broker is ahead of the Db.
If the broker is behind, it will always obtain a lease due to incorrect adjustment.
If the clocks are in sync there is no issue.

<persistenceAdapter>
        <jdbcPersistenceAdapter dataSource="#oracle-ds" lockKeepAlivePeriod="5000">
            <locker>
                <lease-database-locker lockAcquireSleepInterval="10000"/>
            </locker>
        </jdbcPersistenceAdapter>
    </persistenceAdapter>

The problem is that the negative diff is being treated as a positive diff.