[AMQ-3920] Performance issue with delay policy in DestinationBridge.onMessage

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 5.6.0
• Fix Version/s: 5.7.0
• Component/s: Broker
• Assignee: Timothy A. Bish
• Reporter: Sergey Ermakov
• Created: 10/Jul/12 14:28
• Updated: 10/Jul/12 20:09
• Resolved: 10/Jul/12 20:09

Description

Incorrect sleep implementation in org.apache.activemq.network.jms.DestinationBridge.onMessage

In the current implementation the condition 'attempt > 0' is true during the first iteration. It causes critical performance problems in high load environment.

Code example from DestinationBridge.onMessage:
...
while (started.get() && message != null && ++attempt <= maxRetries) {

try {

if (attempt > 0) {//IT'S TRUE DURING FIRST ITERATION
try

{ Thread.sleep(jmsConnector.getReconnectionPolicy().getNextDelay(attempt)); }

catch(InterruptedException e)

{ break; }

}
...