[AMQ-3856] MessageServlet assumes TextMessages contain Text

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.5.1, 5.6.0
• Fix Version/s: 5.7.0
• Component/s: Broker

Environment

all

• Assignee: Timothy A. Bish
• Reporter: Alan Hudson
• Created: 22/May/12 21:56
• Updated: 29/May/12 14:21
• Resolved: 29/May/12 14:21

Description

writeMessageResponse assumes that a text message will contain non null text. It does a txt.startsWith which crashes with TextMessages with no body.

It can be fixed with this code:

protected void writeMessageResponse(PrintWriter writer, Message message) throws JMSException, IOException {
if (message instanceof TextMessage) {
TextMessage textMsg = (TextMessage)message;
String txt = textMsg.getText();

if (txt != null) {
if (txt.startsWith("<?"))

{ txt = txt.substring(txt.indexOf("?>") + 2); }

writer.print(txt);
}
} else if (message instanceof ObjectMessage)

{ ObjectMessage objectMsg = (ObjectMessage)message; Object object = objectMsg.getObject(); writer.print(object.toString()); }

}