[AMQ-3845] CachedLDAPAuthorizationMap doesn't handle the ldap connectino dying

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.6.0
• Fix Version/s: 5.7.0
• Component/s: Broker
• Labels: authorization ldap quick_to_fix security
• Assignee: Dejan Bosanac
• Reporter: Mike Bryant
• Created: 16/May/12 14:05
• Updated: 11/Jun/12 09:29
• Resolved: 11/Jun/12 09:29

Description

If the ldap connection dies for some reason (ldap server restarting etc.), the broker will continue to attempt to use the old connection for authorization, resulting in all attempts to use the broker being denied.

In CachedLDAPAuthorizationMap.java, the open() function just returns the context if one exists. Instead, it should check to see if the context is still valid, and if not create one.

Alternatively, the caching of the ldap connection can be removed entirely, and then in the refreshInterval>0 case, a new ldap connection will be made each refresh interval (default setting: every 5 minutes).
i.e. delete these lines:
if (context != null)

{ return context; }

Issue Links

• is related to: AMQ-3791 Flexibility, concurrency, security, and compatibility issues in CachedLDAPAuthorizationMap