[AMQ-3828] URISupport incorrectly handles parenthesis

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.5.1
• Fix Version/s: 5.7.0
• Component/s: Transport
• Labels: CompositeData URI parser
• Assignee: Timothy A. Bish
• Reporter: Fernando Rafael Ferreira
• Created: 04/May/12 11:59
• Updated: 15/Sep/23 14:04
• Resolved: 12/Jun/12 21:10

Description

URISupport.parseComposite(URI) incorrectly parses an URI with a closing parenthesis ")" in the query part.

// The URI is parsed incorrectly when there is an unescaped ')'
URI uri = new URI("failover://()?updateURIsURL=file:/C:/Dir(1)/a.csv");
CompositeData data = URISupport.parseComposite(uri);

// Parsed Composite Data:
// - Components: [)?updateURIsURL=file:/C:/Dir(1]
// -   Fragment: null
// -       Host: 
// - Parameters: {}
// -       Path: a.csv
// -     Scheme: failover

// The URI is parsed correctly when it is an escaped
URI uri = new URI("failover://()?updateURIsURL=file:/C:/Dir%281%29/a.csv");
CompositeData data = URISupport.parseComposite(uri);
	
// Parsed Composite Data: 
// - Components: []
// -   Fragment: null
// -       Host: 
// - Parameters: {updateURIsURL=file:/C:/Dir(1)/a.csv}
// -       Path: null
// -     Scheme: failover

I think URISupport should either throw an URISyntaxException or parse it correctly.
See RFC2396:

Unreserved characters can be escaped without changing the semantics
of the URI, but this should not be done unless the URI is being used
in a context that does not allow the unescaped character to appear.

By the way, the problem occurs in the method parseComposite(URI uri, CompositeData rc, String ssp), at:

...
p = ssp.lastIndexOf(")");
...