[AMQ-3792] use of the failover transport incorrectly suppresses javax.jms.InvalidClientIDException when clientId is already in use

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.5.1
• Fix Version/s: 5.6.0
• Component/s: Broker
• Labels: InvalidClientIDException failover
• Assignee: Gary Tully
• Reporter: Gary Tully
• Created: 29/Mar/12 22:00
• Updated: 10/Jul/13 07:37
• Resolved: 29/Mar/12 22:36

Description

Chucking an javax.jms.InvalidClientIDException is currently conditional on the connection not being fault tolerant and not being a network connector which seems incorrect.
In both cases, a duplicate connection is still a duplicate and we should wait till it is cleaned up/disposed.

A failover variant of the test from https://issues.apache.org/jira/browse/AMQ-463 demonstrates.

This change was introduced in http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/RegionBroker.java?annotate=633800 but it looks like suppression of a duplicate connectionId in TransportConnector is sufficient for the reconnect case.