Couple tests keep an eye on the logging for specific failures, be good to have a common approach to this.
NPE in LastImageSubscriptionRecoveryPolicy
Patch adds DefaultTestAppender and modifies the two existing tests to use it.
improvement applied with thanks.
note for the future, every new file needs the apache copyright header
I looked at the patch and I just noticed that the appender is added to the logging system but it is not removed when the test has completed.
Since the appender references the test case then the test case instance will never be reclaimed until the logging system is removed and that is when the application ends.
Would you consider adding the code that remove the added appender when the test has completed.
Yeah, totally agree, sorry I missed that. We get away with it currently because of the way the tests are run but it's best the test cleans that up, will attach a second patch momentarily.
Created AMQ-3628 for the fix since this feature's been added.