[AMQ-3516] Failover Transport MessageAck commands aren't filtered in oneway

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.x
• Fix Version/s: 5.6.0
• Component/s: Transport
• Assignee: Timothy A. Bish
• Reporter: Timothy A. Bish
• Created: 28/Sep/11 20:00
• Updated: 29/Sep/11 16:04
• Resolved: 29/Sep/11 16:04

Description

There's some code in FailoverTransport.oneway that was intended to MessageAck commands when the transport was in a failed state that will never be called.

                if (isShutdownCommand(command) && connectedTransport.get() == null) {
                    if (command.isShutdownInfo()) {
                        // Skipping send of ShutdownInfo command when not
                        // connected.
                        return;
                    }
                    if (command instanceof RemoveInfo || command.isMessageAck()) {
                        // Simulate response to RemoveInfo command or ack (as it
                        // will be stale)
                        stateTracker.track(command);
                        Response response = new Response();
                        response.setCorrelationId(command.getCommandId());
                        myTransportListener.onCommand(response);
                        return;
                    }
                }

The inner if statement that looks for MessageAck will never be reachable since a MessageAck is not a RemoveInfo or ShutdownInfo command which is the condition for getting into the outer if.