[AMQ-3514] MessageListenerServlet does not clear the timer on destroy

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 5.5.0
• Fix Version/s: 5.6.0
• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Johannes
• Created: 28/Sep/11 16:06
• Updated: 29/Sep/11 11:40
• Resolved: 28/Sep/11 19:36

Description

Hi,

we are debugging a shutdown problem using the activemq-web-console deployed into jetty.

It seems as if everything is terminated as expected, apart from a TimerThread which logs to the console about every minute.

05 Jul 2011 09:03:19,246 DEBUG [Timer-1] org.apache.activemq.web.MessageListenerServlet.debug() – Cleaning up expired web clients.

Tracing down the problem indicated one possible cause.
The web-console package declares the AjaxServlet to send messages via the web to the broker, it extends MessageListenerServlet.

The init() mehtod of the MessageListenerServlet schedules task

clientCleanupTimer.schedule( new ClientCleaner(), 5000, 60000 );

but the timer (clientCleanupTimer) is never canceled and according to the javadoc of Timer this can prevent the JVM from shutting down cleanly.

Patch attached