[AMQ-3465] TransactionContext produces errors in concurrent environment

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.5.0
• Fix Version/s: 5.6.0
• Component/s: Broker

Environment

Windows XP SP2, Oracle JDK 1.6.0_23

• Assignee: Timothy A. Bish
• Reporter: Alexei Akimov
• Created: 23/Aug/11 12:52
• Updated: 31/Jan/13 13:11
• Resolved: 03/Oct/11 12:44

Description

Method "isInXATransaction" of class org.apache.activemq.TransactionContext seems to be implemeted incorrectly. Here is the code:

public boolean isInXATransaction() {
return (transactionId != null && transactionId.isXATransaction()) || !ENDED_XA_TRANSACTION_CONTEXTS.isEmpty();
}

Map "ENDED_XA_TRANSACTION_CONTEXTS" is a static field. TransactionContext instances are used for both outbound and inbound communications. Suppose a thread creating a new non-transactional session. It calls isInXATransaction and gets true, just because another thread is completing transactional message delivery at the same time. After XAResource.end() call but before XAResource.commit() call the map is not empty and it results in a JMSException in the first thread (see org.apache.activemq.ra.ManagedTransactionContext.setUseSharedTxContext(boolean)").

Issue Links

• is duplicated by: AMQ-4287 REOPEN - javax.jms.JMSException: The resource is allready being used in transaction context.
• is duplicated by: AMQ-3602 javax.jms.JMSException: The resource is allready being used in transaction context.